docs: Fix spelling errors in Generals/Code/GameEngine/Source comments #2145

bobtista · 2026-01-18T23:56:31Z

Fix spelling errors in code comments.

greptile-apps · 2026-01-18T23:58:29Z

Greptile Summary

This PR corrects spelling errors across 90 C++ source files in the Generals/Code/GameEngine/Source directory. All changes are confined to code comments only - no actual code logic, function names, or variable names were modified.

Common corrections made:

definitons → definitions
extention → extension (18 instances in AIDock.cpp alone)
althought → although
wierd → weird
emtpy → empty
poiner → pointer
contructor → constructor
precendence → precedence
indicitive → indicative

The PR maintains perfect symmetry with 211 insertions and 211 deletions, confirming pure line replacements. No copyright headers, code logic, or whitespace was altered.

Confidence Score: 5/5

This PR is safe to merge with zero risk - only comment spelling corrections
Score of 5 reflects that this is a documentation-only change affecting comments across 90 files. All modifications are spelling corrections with no impact on compiled code, runtime behavior, or build process. Perfect insertion/deletion symmetry confirms no logic changes.
No files require special attention - all changes are benign spelling corrections

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Source/GameLogic/AI/AIDock.cpp	Fixed 18 spelling errors: "extention" -> "extension"
Generals/Code/GameEngine/Source/GameClient/InGameUI.cpp	Fixed 13 spelling errors: althought->although, emtpy->empty, wierd->weird, poiner->pointer, contructor->constructor, indicitive->indicative, precendence->precedence
Generals/Code/GameEngine/Source/GameClient/GUI/ControlBar/ControlBar.cpp	Fixed 7 spelling errors in comments
Generals/Code/GameEngine/Source/GameClient/GUI/GameWindowManager.cpp	Fixed 7 spelling errors in comments
Generals/Code/GameEngine/Source/GameLogic/Object/Object.cpp	Fixed 10 spelling errors in comments

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Files as 90 Source Files
    participant Comments as Code Comments
    participant Docs as Documentation Quality
    
    Dev->>Files: Identify spelling errors
    Files->>Comments: Scan comment text
    Comments-->>Dev: Return misspelled words
    Note over Comments: definitons, extention, althought,<br/>wierd, emtpy, poiner, etc.
    Dev->>Comments: Apply corrections
    Comments->>Comments: Replace misspellings
    Note over Comments: definitions, extension, although,<br/>weird, empty, pointer, etc.
    Comments->>Docs: Improve readability
    Docs-->>Dev: Enhanced documentation quality

Generals/Code/GameEngine/Source/Common/System/BuildAssistant.cpp

Generals/Code/GameEngine/Source/GameLogic/Object/Object.cpp

Generals/Code/GameEngine/Source/Common/RTS/SpecialPower.cpp

Generals/Code/GameEngine/Source/GameClient/InGameUI.cpp

Generals/Code/GameEngine/Source/GameLogic/Object/Collide/CollideModule.cpp

Generals/Code/GameEngine/Source/GameLogic/Object/Update/EMPUpdate.cpp

xezon

Looking good.

xezon · 2026-01-22T17:48:09Z

I do not understand the splitting of this change. The title claims one thing, but the actual changes files are in all sorts of unrelated folders that do correspond to what the title says.

greptile-apps

Additional Comments (2)

Generals/Code/GameEngine/Source/GameLogic/ScriptEngine/ScriptActions.cpp, line 2747 (link)

syntax: Method renamed from setUninterruptable to setUninterruptible in AudioEventRTS.h but call site not updated - will cause compilation error.
Core/GameEngine/Source/Common/Audio/GameAudio.cpp, line 438 (link)

style: Comment still uses old spelling "uninterruptable" - should be updated to "uninterruptible" for consistency with the renamed API.

_{141 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-01-22T21:27:20Z

Generals/Code/Tools/WorldBuilder/src/wbview3d.cpp

 	if (m_ww3dInited) {
-		W3DShaderManager::shutdown();
 		WW3D::Set_Device_Resolution(m_actualWinSize.x, m_actualWinSize.y, true);
-		W3DShaderManager::init();
 	}


logic: Removed W3DShaderManager::shutdown() and W3DShaderManager::init() calls - this appears to be unrelated to spelling corrections and may cause shader management issues during resolution changes. Was this shader cleanup intentional or accidentally included in this spelling fix PR?

Prompt To Fix With AI

This is a comment left during a code review. Path: Generals/Code/Tools/WorldBuilder/src/wbview3d.cpp Line: 576:578 Comment: **logic:** Removed `W3DShaderManager::shutdown()` and `W3DShaderManager::init()` calls - this appears to be unrelated to spelling corrections and may cause shader management issues during resolution changes. Was this shader cleanup intentional or accidentally included in this spelling fix PR? How can I resolve this? If you propose a fix, please make it concise.

xezon · 2026-01-23T18:12:28Z

Generals/Code/GameEngine/Source/GameLogic/Object/WeaponSet.cpp

 				if( commandSource == CMD_FROM_PLAYER && (!victim->testScriptStatusBit( OBJECT_STATUS_SCRIPT_TARGETABLE ) || r == ALLIES) )
 				{
-					//Unless the object has a map propertly that sets it to be targetable (and not allied), then give up.
+					//Unless the object has a map properly that sets it to be targetable (and not allied), then give up.


xezon

Why does this change not also fix errors in Generals/Code/GameEngine/Inlcude like the Zero Hour change does?

bobtista · 2026-01-23T18:49:16Z

Why does this change not also fix errors in Generals/Code/GameEngine/Inlcude like the Zero Hour change does?

I was trying to keep files changed below 100 - I added the changes that Zero Hour (2146) does here it was only 16 more files.

Caball009 reviewed Jan 19, 2026

View reviewed changes

Generals/Code/GameEngine/Source/Common/System/BuildAssistant.cpp Outdated Show resolved Hide resolved

Generals/Code/GameEngine/Source/GameLogic/Object/Object.cpp Outdated Show resolved Hide resolved

xezon added the Documentation Is documentation or complementary resource label Jan 19, 2026

xezon reviewed Jan 19, 2026

View reviewed changes

xezon approved these changes Jan 19, 2026

View reviewed changes

greptile-apps bot reviewed Jan 22, 2026

View reviewed changes

bobtista added 5 commits January 22, 2026 15:27

docs: Fix spelling errors in engine comments

c1f858a

docs: Fix spelling errors in Generals/Code/GameEngine/Source comments

1602d3f

docs: Fix does't typo to doesn't

0c18fda

nit: comment fixes

4115531

refactor: Keep only Generals/Code/GameEngine/Source files in this PR

2551640

bobtista force-pushed the fix/typos-generals-source branch from 7f6136c to 2551640 Compare January 22, 2026 21:29

xezon reviewed Jan 23, 2026

View reviewed changes

bobtista added 2 commits January 23, 2026 10:34

fix: properly to property in Generals WeaponSet

0513660

docs: Fix spelling errors in Generals/Code/GameEngine/Include comments

5ae36ca

xezon mentioned this pull request Jan 29, 2026

docs: Fix spelling errors in Core and Generals/Include/GameEngineDevice/Libraries/Tools comments #2147

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Fix spelling errors in Generals/Code/GameEngine/Source comments #2145

docs: Fix spelling errors in Generals/Code/GameEngine/Source comments #2145

Uh oh!

bobtista commented Jan 18, 2026

Uh oh!

greptile-apps bot commented Jan 18, 2026 •

edited

Loading

Greptile Summary

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xezon left a comment

Uh oh!

xezon commented Jan 22, 2026

Uh oh!

greptile-apps bot left a comment •

edited

Loading

Uh oh!

greptile-apps bot Jan 22, 2026

Uh oh!

xezon Jan 23, 2026

Uh oh!

xezon left a comment

Uh oh!

bobtista commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

docs: Fix spelling errors in Generals/Code/GameEngine/Source comments #2145

Are you sure you want to change the base?

docs: Fix spelling errors in Generals/Code/GameEngine/Source comments #2145

Uh oh!

Conversation

bobtista commented Jan 18, 2026

Uh oh!

greptile-apps bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xezon left a comment

Choose a reason for hiding this comment

Uh oh!

xezon commented Jan 22, 2026

Uh oh!

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Additional Comments (2)

Uh oh!

greptile-apps bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

xezon Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

xezon left a comment

Choose a reason for hiding this comment

Uh oh!

bobtista commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

greptile-apps bot commented Jan 18, 2026 •

edited

Loading

greptile-apps bot left a comment •

edited

Loading